Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in JS code in AlertOverride #8043

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

havja
Copy link
Contributor

@havja havja commented Feb 20, 2020

Changed the __webdriverPrompt to __webdriverPrompts in the window.prompt function.

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@claassistantio
Copy link

claassistantio commented Feb 20, 2020

CLA assistant check
All committers have signed the CLA.

Changed the __webdriverPrompt to __webdriverPrompts in the window.prompt function.
@havja havja force-pushed the alert-override-typo branch from 095f93d to 2c702a4 Compare February 24, 2020 13:34
@AutomatedTester AutomatedTester merged commit 66d9320 into SeleniumHQ:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants